Re: [g-a-devel] [PATCH] minor changes to gnome-mag code

[Bill Haneman <Bill Haneman Sun COM>]

Hi Carlos:

Thanks for doing this work!  I suggest that we use bugzilla to discuss
the patch further.  I am also really happy that you are getting more
familiar with the code, and hope to help in any way that I can.

I think that improving the consistency of formatting is a great idea. 
One disadvantage, though, is that you lose the code attribution that
way, i.e. you don't know who wrote which lines of code, or when certain
code changes were made, since the re-formatting will change all those
lines.

So I would suggest making the smallest possible patch that makes the
style consistent, even if that means we differ a little from the GNU
style.  For instance, I would request that you don't change the left
brackets ('{') appear at the ends of "if()", but leave them on their own
lines; this will preserve more of the code attribution.  Otherwise I
think it's great.

Thanks again!

Bill

On Wed, 2006-03-08 at 18:46, Carlos Eduardo Rodrigues Di�es wrote:
> Hi,
> 
> This patch removes the <sys/time.h> from magnifier-main.c, that is not
> necessary.
> 
> In the test to see if the user pass the target_display argument, I
> changed the putenv by a g_setenv, what in my understand is more portable
> than putenv.
> 
> >From magnifier.c it's remove the duplicate prototype of
> magnifier_init_window ().
> 
> In the impl_zoom_region_set_mag_factor () in zoom-region.c, where have
> the TODO i put the following:
> 
> g_assert (IS_MAGNIFIER ((Magnifier *) zoom_region->priv->parent));
> 
> I don't know if is this that must be done, so comments are welcome.
> 
> I'm reading a lot the code to try to understand the program better. So,
> I'm also trying to make the code more consistent, i.e., chaging the
> identation in some places and the open bracket in if and for statements.
> I'm also breaking lines that pass 80 columns when I think that it will
> be more confortable to read and when it's possibly. All these changes
> are been made with the GNOME Programming Guidelines and the GNU
> Standards in mind, but more have to be done to leave the code more
> consistent in my point of view.
> 
> Bill, if you think that this is OK, please commit. My CVS account was
> created, but I don't have a password to access it.
> 
> Thanks,
> -- 
> Carlos Eduardo Rodrigues Di�es
> 
> ______________________________________________________________________
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel