[g-a-devel] at-spi bridge fix ...



Hi there,

	So - this shouldn't be controversial, it's a trivial change - might
improve performance of event emission by some tiny amount too. Also -
it's really a rather important fix for OO.o's multi-threaded at-spi
bridge usage; for various nasty & hard-to-explain reasons :-)

	HTH,

		Michael.

-- 
 michael meeks novell com  <><, Pseudo Engineer, itinerant idiot
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/at-spi/ChangeLog,v
retrieving revision 1.482
diff -u -p -u -r1.482 ChangeLog
--- ChangeLog	2 Nov 2005 22:34:36 -0000	1.482
+++ ChangeLog	16 Nov 2005 10:18:31 -0000
@@ -1,3 +1,10 @@
+2005-11-16  Michael Meeks  <michael meeks novell com>
+
+	* atk-bridge/bridge.c (spi_atk_emit_eventv):
+	do a faster, less problematic _unref call on this local
+	object, rather than a slower (potentially cross-thread
+	complicated) CORBA call.
+
 2005-11-02  Kjartan Maraas  <kmaraas gnome org>
 
 	* atk-bridge/bridge.c: (spi_atk_bridge_signal_listener):
Index: atk-bridge/bridge.c
===================================================================
RCS file: /cvs/gnome/at-spi/atk-bridge/bridge.c,v
retrieving revision 1.85
diff -u -p -u -r1.85 bridge.c
--- atk-bridge/bridge.c	2 Nov 2005 18:01:10 -0000	1.85
+++ atk-bridge/bridge.c	16 Nov 2005 10:18:31 -0000
@@ -661,7 +661,7 @@ spi_atk_emit_eventv (const GObject      
 		   CORBA_exception_id(&ev));
 #endif	      
       if (BONOBO_EX (&ev)) registry_died = TRUE;
-      Accessibility_Accessible_unref (e.source, &ev);
+      bonobo_object_unref (BONOBO_OBJCT (source));
       
       CORBA_exception_free (&ev);
       


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]