Re: [g-a-devel]gnopernicus/kbd_mouse/libke/libke.c

[Marc Mulcahy <marc mulcahy sun com>]

Hi Guys,

This may be stylistic, but I notice lots of commented out code, using 
both comment tags (/* */) and #if 0 #endif

This makes the code really hard to read and review, mainly because it's 
difficult to determine what code is actually current and running.  For 
example, in the Braille code, there is code which uses the glib main 
loop to poll the Braille display, and there is also code using signals 
to set timers to do polling and the like.  And obviously one code path 
isn't active.  This seems to me to be the reason for CVS, I.E. when you 
remove code, rather than commenting it out, remove it outright-- it'll 
still be available in cvs.

Regards,

Marc

On Thu, 23 Jan 2003, Paul Sprencz wrote:

> 
> Hi Padraig
> 
> Its used earlier but now its not use. Thats defines used for the keyset, 
> whiches the application listen, only this keys lsitened. This solustion 
> is wrong, because Solaris has other keycodes. Thats defines will be 
> commented. 
> 
> Regards
>     Paul
> 
> 
> >
> >----------  Forwarded Message  ----------
> >
> >Subject: [g-a-devel]gnopernicus/kbd_mouse/libke/libke.c
> >Date: Thu, 23 Jan 2003 11:28:52 +0000 (GMT)
> >From: "Padraig O'Briain" <Padraig Obriain Sun COM>
> >To: gnome-accessibility-devel gnome org
> >
> >I happended to be looking ath the code of this file and I noticed that it
> > seems to be Linux specific in that the has defines KEYCODE_KP_0 etc. have
> > values which are corrected for Linux but not for Solaris.
> >
> >Is this code intended to work on Solaris?
> >
> >Padraig
> >
> >_______________________________________________
> >Gnome-accessibility-devel mailing list
> >Gnome-accessibility-devel gnome org
> >http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel
> >
> >-------------------------------------------------------
> >
> 
> 
> 
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel
>