[g-a-devel]Fix to at-poke



The attached patch prevents at-poke core dumping after the application being 
poked terminated.

I will apply unless there are objections.

Padraig

? config.h.in
? icons/Makefile
? icons/Makefile.in
cvs server: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/at-poke/ChangeLog,v
retrieving revision 1.31
diff -u -p -r1.31 ChangeLog
--- ChangeLog	30 Aug 2002 09:57:40 -0000	1.31
+++ ChangeLog	4 Sep 2002 09:50:08 -0000
@@ -1,3 +1,10 @@
+2002-09-03  Padraig O'Briain   <padraig obriain sun com>
+
+	* src/main.c
+	(application_clicked); Check that there is a selected application
+	(popuplate_app_list): Unset app_window->selected if no application.
+	This fixes bug #91997.
+
 2002-08-30  Padraig O'Briain   <padraig obriain sun com>
 
 	* src/accessible-tree-model.c
cvs server: Diffing glade
cvs server: Diffing icons
cvs server: Diffing src
Index: src/main.c
===================================================================
RCS file: /cvs/gnome/at-poke/src/main.c,v
retrieving revision 1.11
diff -u -p -r1.11 main.c
--- src/main.c	10 Jul 2002 10:17:26 -0000	1.11
+++ src/main.c	4 Sep 2002 09:50:08 -0000
@@ -131,8 +131,12 @@ static void
 application_clicked (GtkButton *button,
 		     AppWindow *app_window)
 {
-	validate_up_down_linkage (app_window->selected);
-	poke (app_window->selected);
+	if (!app_window->selected)
+		gdk_beep ();
+	else {
+		validate_up_down_linkage (app_window->selected);
+		poke (app_window->selected);
+	}
 }
 
 static void
@@ -172,6 +176,8 @@ populate_app_list (AppWindow *app_window
 		GTK_TREE_MODEL (app_window->list_store), &iter))
 		gtk_tree_selection_select_iter (
 			gtk_tree_view_get_selection (app_window->list_view), &iter);
+	else
+		app_window->selected = NULL;
 
 	Accessible_unref (desktop);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]