Re: [g-a-devel]Patch for at-spi bug 95517

[Bill Haneman <bill haneman sun com>]

On Fri, 2002-10-11 at 16:33, Padraig O'Briain wrote:
> While attempting to add support for hyperlinks I came across what I beleieve is 
> a bug in at-spi, 95517.

Please commit; you are right, this is a bug.  I believe there was some
confusion at one time about AtkHyperlinks being AtkObjects; they are
not.

-Bill

> Patch attached.
> 
> May I commit?
> 
> Padraig
> ----
> 

> cvs server: Diffing .
> Index: hyperlink.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/libspi/hyperlink.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 hyperlink.c
> --- hyperlink.c	13 Sep 2002 13:09:00 -0000	1.15
> +++ hyperlink.c	11 Oct 2002 15:30:02 -0000
> @@ -84,7 +84,7 @@ spi_hyperlink_init (SpiHyperlink *hyperl
>  
>  
>  SpiHyperlink *
> -spi_hyperlink_new (AtkObject *object)
> +spi_hyperlink_new (AtkHyperlink *object)
>  {
>    SpiHyperlink *new_hyperlink = g_object_new (
>  	  SPI_HYPERLINK_TYPE, NULL);
> @@ -101,7 +101,7 @@ get_hyperlink_from_servant (PortableServ
>    SpiBase *object = SPI_BASE (bonobo_object_from_servant (servant));
>  
>    g_return_val_if_fail (object != NULL, NULL);
> -  g_return_val_if_fail (ATK_IS_OBJECT(object->gobj), NULL);
> +  g_return_val_if_fail (ATK_IS_HYPERLINK(object->gobj), NULL);
>    return ATK_HYPERLINK (object->gobj);
>  }
>  
> Index: hyperlink.h
> ===================================================================
> RCS file: /cvs/gnome/at-spi/libspi/hyperlink.h,v
> retrieving revision 1.9
> diff -u -p -r1.9 hyperlink.h
> --- hyperlink.h	13 Sep 2002 13:09:00 -0000	1.9
> +++ hyperlink.h	11 Oct 2002 15:30:02 -0000
> @@ -48,7 +48,7 @@ struct _HyperlinkClass {
>  };
>  
>  GType         spi_hyperlink_get_type (void);
> -SpiHyperlink *spi_hyperlink_new      (AtkObject *object);
> +SpiHyperlink *spi_hyperlink_new      (AtkHyperlink *object);
>  
>  G_END_DECLS
>  
> Index: hypertext.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/libspi/hypertext.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 hypertext.c
> --- hypertext.c	13 Sep 2002 13:09:00 -0000	1.14
> +++ hypertext.c	11 Oct 2002 15:30:02 -0000
> @@ -79,7 +79,7 @@ impl_getLink (PortableServer_Servant ser
>    link = atk_hypertext_get_link (hypertext, linkIndex);
>    g_return_val_if_fail (link != NULL, CORBA_OBJECT_NIL);
>  
> -  rv = BONOBO_OBJREF (spi_hyperlink_new (ATK_OBJECT (link)));
> +  rv = BONOBO_OBJREF (spi_hyperlink_new (link));
>  
>    return CORBA_Object_duplicate (rv, ev);
>  }