Re: [g-a-devel]at-spi patch for bug 95055

[Bill Haneman <bill haneman sun com>]

On Mon, 2002-10-07 at 15:19, Padraig O'Briain wrote:
> This patch ensure that the strings returned by AccessibleRole_getName() and 
> Accessible_getRoleName() are the same.
> 
> OK to commit?

This patch appears to change the strings returned by
AccessibleRole_getName().  Normally I would think we should be reluctant
to change string values returned (for a number of compat reasons), but
since the method is deprecated it's probably OK.  However, since
AccessibleRole_getName() has been deprecated in favor of
Accessible_getRoleName() [see the API docs], we probably shouldn't be
messing with it at all.

-Bill

> Padraig
> ----
> 

> cvs server: Diffing .
> Index: spi_accessible.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/cspi/spi_accessible.c,v
> retrieving revision 1.40
> diff -u -p -r1.40 spi_accessible.c
> --- spi_accessible.c	13 Sep 2002 13:08:58 -0000	1.40
> +++ spi_accessible.c	7 Oct 2002 14:09:54 -0000
> @@ -26,73 +26,73 @@
>  
>  static const char *role_names [] =
>  {
> -  "<invalid>",
> -  "accelerator label",
> +  "invalid",
> +  "accel-label",
>    "alert",
>    "animation",
>    "arrow",
>    "calendar",
>    "canvas",
> -  "check box",
> -  "check menu item",
> -  "color chooser",
> -  "column header",
> -  "combo box",
> -  "date editor",
> -  "desktop icon",
> -  "desktop frame",
> +  "check-box",
> +  "check-menu-item",
> +  "color-chooser",
> +  "column-header",
> +  "combo-box",
> +  "date-editor",
> +  "desktop-icon",
> +  "desktop-frame",
>    "dial",
>    "dialog",
> -  "directory pane",
> -  "drawing area",
> -  "file chooser",
> +  "directory-pane",
> +  "drawing-area",
> +  "file-chooser",
>    "filler",
> -  "font chooser",
> +  "font-chooser",
>    "frame",
> -  "glass pane",
> -  "HTML container",
> +  "glass-pane",
> +  "html-container",
>    "icon",
>    "image",
> -  "internal frame",
> +  "internalframe",
>    "label",
> -  "layered pane",
> +  "layered-pane",
>    "list",
> -  "list item",
> +  "list-item",
>    "menu",
> -  "menubar",
> -  "menu item",
> -  "option pane",
> -  "page tab",
> -  "page tab list",
> +  "menu-bar",
> +  "menu-item",
> +  "option-pane",
> +  "page-tab",
> +  "page-tab-list",
>    "panel",
> -  "password text",
> -  "popup menu",
> -  "progress bar",
> -  "pushbutton",
> -  "radiobutton",
> -  "radio menu item",
> -  "root pane",
> -  "row header",
> -  "scrollbar",
> -  "scrollpane",
> +  "password-text",
> +  "popup-menu",
> +  "progress-bar",
> +  "push-button",
> +  "radio-button",
> +  "radio-menu-item",
> +  "root-pane",
> +  "row-header",
> +  "scroll-bar",
> +  "scroll-pane",
>    "separator",
>    "slider",
> -  "spin button",
> -  "split pane",
> -  "status bar",
> +  "spin-button",
> +  "split-pane",
> +  "statusbar",
>    "table",
> -  "table cell",
> -  "table column header",
> -  "table row header",
> -  "tearoff menu item",
> +  "table-cell",
> +  "table-column-header",
> +  "table-row-header",
> +  "tear-off-menu-item",
>    "terminal",
>    "text",
> -  "toggle button",
> -  "toolbar",
> -  "tooltip",
> +  "toggle-button",
> +  "tool-bar",
> +  "tool-tip",
>    "tree",
> -  "tree table",
> -  "<unknown>",
> +  "tree-table",
> +  "unknown",
>    "viewport",
>    "window",
>  
> cvs server: Diffing bonobo