[g-a-devel]Another at-poke change



Thie attached patch fixes the crasher bug reported in bug 94849.

When a node is unreffed because its parent was collapsed there are problems if 
we call mnode_destroy(). The value node->data will be pointing to unallocated 
memory. If we set it to NULL then when the parent is expanded we do not have the 
value of the Accessible in the node. Omitting the call to mnode_destroy() at 
this point seems to fix all these problem.

OK to commit?

Padraig
cvs server: Diffing .
Index: accessible-tree-model.c
===================================================================
RCS file: /cvs/gnome/at-poke/src/accessible-tree-model.c,v
retrieving revision 1.22
diff -u -p -r1.22 accessible-tree-model.c
--- accessible-tree-model.c	2 Oct 2002 14:45:18 -0000	1.22
+++ accessible-tree-model.c	4 Oct 2002 16:05:40 -0000
@@ -534,8 +534,6 @@ accessible_tree_model_unref_node (GtkTre
 		if (model->root == node) {
 			model_node_destroy (tree_model, node);
 			model->root = NULL;
-		} else {
-			mnode_destroy (model, mnode);
 		}
 	}
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]