Re: [g-a-devel]Patch for bug 91993 in at-poke

[Michael Meeks <michael ximian com>]

Hi Padraig,

On Tue, 2002-10-01 at 13:25, Padraig O'Briain wrote:
> The attached patch fixes bug 91993; it does not attempt to select two elements 
> when no element is selected.

> +		if (role == SPI_ROLE_TABLE_COLUMN_HEADER) {
> +			Accessible_unref (child);
> +			continue;

	Sounds good to me, but this:

> +static void
> +selection_changed_cb (GtkTreeSelection *tree_selection, Poker *poker)
> +{
> +	/*
> +	 * When one clicks on a row in the TreeView which currently does not
> +	 * have any row selected one first gets notification of selection for 
> +	 * the first row and then a subsequent notification for the selected
> +	 * row if it is different from the first row.
> +	 */
> +	if (!poker->selection_changed_idle_id)
> +		poker->selection_changed_idle_id = gtk_idle_add (do_selection, poker);
>  }

	Looks pretty ghastly; ? What happens on the wire when you select a
table, that hasn't had any row selected before ? is this a gtk+
limitation ? why do we have to work around it here ? surely this is just
a large man-trap waiting for other people ?

	Then again - I don't quite understand the existing selection_changed_cb
I must confess; it's always interesting to try and work out who is the
master / slave in all of this really.

	Curious as to why we have to have an 'idle' handler there, the
potential for race conditions etc.

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot