Re: [g-a-devel]at-spi patch (bugfixes and extended events)

[Michael Meeks <michael ximian com>]

Hi Bill,

On Fri, 2002-11-22 at 13:42, Bill Haneman wrote:
> > > +static char *
> > > +cspi_internal_event_get_object (const InternalEvent *e)
> > > +{
> > > +  CORBA_any *any;
> > > +  g_return_val_if_fail (e, NULL);
> > > +  g_return_val_if_fail (e->data, NULL);
> > > +  any = (CORBA_any *) e->data;
> > > +  if (any->_type == TC_CORBA_Object) 
> > > +    return cspi_object_add (* (CORBA_Object *) any->_value);
> > 
> > 	This looks bogus to me; we should be using the
> > 
> > 	cspi_object_borrow, (and vitally) cspi_object_return 'loan' concept
> > here to minimise round-trip referencing. cspi_object_add does a
> > reference ownership transfer which we don't want here.
> 
> Will fix as time permits, thanks.

	This is a serious crasher / mem corrupter; if you just want to leak,
you need to add a bonobo_object_dup_ref or somesuch to the 
reference.

	It'd also be great to fix the other bits ;-)

	HTH,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot