Re: [g-a-devel]new version of at-spi patch for device/mouse event listeners

[Michael Meeks <michael ximian com>]

Hi Bill,

On Fri, 2002-11-15 at 20:58, Bill Haneman wrote:
> Attached is a new version of this patch.  I plan to commit tomorrow if
> there are no more issues.

	Overall it looks nice; there are the following issues:

	CORBA_free (&key_set) is bogus; it's a local; you want to free the
buffer you allocated. It's nice to see the event mask allocation stuff
much more efficient though. You're still allocating (and leaking) the
buffer in SPI_deregisterDeviceEventListener, though - that should
definately be a stack allocated [2] array.

	This is not good news:

+  mouse_e.event_string = CORBA_string_dup ("");
...
+  CORBA_free (mouse_e.event_string);

	It's quite sufficient to do:

mouse_e.event_string = "";

> While we're breaking internal API (since I will have to patch
> java-access-bridge anyhow), should we add empty slots so that our
> interfaces have at least four empty slots each?

	Yes - certainly; at least 4 :-)

	HTH,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot