[g-a-devel]at-spi RFC: missing return val in IDL

[Bill Haneman <bill haneman sun com>]

Hi:

In attempting to fix bug #82508 (at-spi/"High"/"major") I discovered
that although there is a boolean return code for
SPI_registerKeystrokeListener(), there is no corresponding return value
in the IDL
(Accessibility_DeviceEventController::registerDeviceEventListener
returns void).

Since the bug cannot be fixed (at least without severe hackery) without
a return value, and adding a boolean return is "safe" with regard to
bincompat, I am asking permission to make the change.

A patch is attached.

Thanks,

-Bill



Index: idl/Accessibility_Registry.idl
===================================================================
RCS file: /cvs/gnome/at-spi/idl/Accessibility_Registry.idl,v
retrieving revision 1.18
diff -u -r1.18 Accessibility_Registry.idl
--- idl/Accessibility_Registry.idl	9 May 2002 10:55:54 -0000	1.18
+++ idl/Accessibility_Registry.idl	31 May 2002 10:57:44 -0000
@@ -226,13 +226,13 @@
 	 *            receive the events synchronously, potentially consuming them,
 	 *            or just be notified asynchronously of those events that have
 	 *            been generated.
-	 * Returns: void
+	 * Returns: %true if successful, %false if not
          *
          * Register to intercept keyboard events, and either pass them on or
          * consume them. 
          *
 	 **/
-        void registerKeystrokeListener (in DeviceEventListener listener,
+        boolean registerKeystrokeListener (in DeviceEventListener listener,
 					in KeySet keys,
 					in ControllerEventMask mask,
 					in KeyEventTypeSeq type,