[g-a-devel]Patch/Question about cspi/bono/cspi-bonobo-listener.c



This patch to cspi_event_list_remove_by_cb in
cspi/bonobo/cspi-bonobo-listener.c seems reasonable.  doesn't the current
implementation simply remove all callbacks?


Index: cspi/bonobo/cspi-bonobo-listener.c
===================================================================
RCS file: /cvs/gnome/at-spi/cspi/bonobo/cspi-bonobo-listener.c,v
retrieving revision 1.11
diff -u -r1.11 cspi-bonobo-listener.c
--- cspi/bonobo/cspi-bonobo-listener.c  13 May 2002 07:49:03 -0000      1.11
+++ cspi/bonobo/cspi-bonobo-listener.c  13 May 2002 16:02:30 -0000
@@ -69,9 +69,12 @@
       EventHandler *eh = l->data;
       next = l->next;

-      list = g_list_delete_link (list, l);
+      if (eh-cb == callback)
+       {
+         list = g_list_delete_link (list, l);

-      cspi_event_handler_free (eh);
+         cspi_event_handler_free (eh);
+       }
     }

   return list;





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]