[g-a-devel]Re: [G2R] at-spi RFC: missing return val in IDL

[Michael Meeks <michael ximian com>]

Hi Bill,

On Fri, 2002-05-31 at 14:05, Bill Haneman wrote:
> In attempting to fix bug #82508 (at-spi/"High"/"major")

	#82508 appears to be an unrelated nautilus bug.

> I discovered
> that although there is a boolean return code for
> SPI_registerKeystrokeListener(), there is no corresponding return value
> in the IDL
> (Accessibility_DeviceEventController::registerDeviceEventListener
> returns void).
> 
> Since the bug cannot be fixed (at least without severe hackery) without
> a return value, and adding a boolean return is "safe" with regard to
> bincompat, I am asking permission to make the change.

	You could simply add an exception, which would be more CORBA-like, and
also have less bincompat impact.

	Either way, the patch is fine - please go ahead, it's not as if people
are using the interface much anyway.

	Again - I would _very_ much prefer the use of exceptions rather than
boolean values, since then we can convey some information about the
likely causes of failure in the IDL / to the user.

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot