Re: [g-a-devel]Re: gnome-mag fixage (patch)

[Bill Haneman <bill haneman sun com>]

On Tue, 2002-12-10 at 10:31, Michael Meeks wrote:
> Hi Bill,
> 
> On Mon, 2002-12-09 at 17:43, Bill Haneman wrote:
> > Thanks for the patch.  It looks good overall.  However there are a
> > couple of issues, I'll mention them below [BH].  If you don't mind
> > making the changes I mention below, than feel free to commit.
> 
> 	I've committed - I attach the patch I committed - I did a few things
> slightly differently - but at least this will give us smaller diffs next
> time:

Thanks Michael!

-Bill
...

> 	I re-wrote these two methods so they do actually do 'dispose-like'
> things, splitting the code from the GObject dispose. It's totally
> unacceptable to have a loop that unrefs to 0, especially when it relies
> on trampling on undefined memory to see if it's finished:
> 
> -	while (IS_MAGNIFIER(magnifier) &&
> -              G_OBJECT (magnifier)->ref_count)
> -		bonobo_object_unref (BONOBO_OBJECT (magnifier));
> 
> 	may well be (one) of the crasher bugs now gone that was killing my
> magnification experience.

Yes, the above code is clearly not right.  Thanks for the fix.

-Bill