[g-a-devel]Patch for bug 90838

["Padraig O'Briain" <Padraig Obriain Sun COM>]

I have attached a proposed patch for bug 90838.

I have included the patch below.

Permission to commit requested.

Padraig

cvs server: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/at-spi/ChangeLog,v
retrieving revision 1.233
diff -u -p -r1.233 ChangeLog
--- ChangeLog	12 Aug 2002 09:49:38 -0000	1.233
+++ ChangeLog	15 Aug 2002 14:55:13 -0000
@@ -1,3 +1,8 @@
+2002-08-15  Padraig O'Briain  <padraig obriain sun com>
+
+	* atk-bridge/bridge.c (spi_atk_bridge_signal_listener):
+	If signal has detail add it to the type of the event.
+	
 2002-08-12  Darren Kenny  <darren kenny sun com>
 
 	* cspi/bonobo/cspi-bonobo-listener.c: 
cvs server: Diffing atk-bridge
Index: atk-bridge/bridge.c
===================================================================
RCS file: /cvs/gnome/at-spi/atk-bridge/bridge.c,v
retrieving revision 1.43
diff -u -p -r1.43 bridge.c
--- atk-bridge/bridge.c	20 Jun 2002 21:37:58 -0000	1.43
+++ atk-bridge/bridge.c	15 Aug 2002 14:55:13 -0000
@@ -590,6 +590,8 @@ spi_atk_bridge_signal_listener (GSignalI
   GObject *gobject;
   GSignalQuery signal_query;
   const gchar *name;
+  const gchar *detail;
+  
   gint detail1 = 0, detail2 = 0;
 #ifdef SPI_BRIDGE_DEBUG
   const gchar *s, *s2;
@@ -598,12 +600,17 @@ spi_atk_bridge_signal_listener (GSignalI
   g_signal_query (signal_hint->signal_id, &signal_query);
 
   name = signal_query.signal_name;
+  if (signal_hint->detail)
+    detail = g_quark_to_string (signal_hint->detail);
+  else
+    detail = NULL;
 
 #ifdef SPI_BRIDGE_DEBUG
   s2 = g_type_name (G_OBJECT_TYPE (g_value_get_object (param_values + 0)));
   s = atk_object_get_name (ATK_OBJECT (g_value_get_object (param_values + 0)));
-  fprintf (stderr, "Received signal %s:%s from object %s (gail %s)\n",
-	   g_type_name (signal_query.itype), name, s ? s : "<NULL>" , s2);
+  fprintf (stderr, "Received signal %s:%s detail: %s from object %s (gail 
%s)\n",
+	   g_type_name (signal_query.itype), name, 
+                        detail ? detail : "<NULL>", s ? s : "<NULL>" , s2);
 #endif
 
   gobject = g_value_get_object (param_values + 0);
@@ -612,12 +619,13 @@ spi_atk_bridge_signal_listener (GSignalI
   if (G_VALUE_TYPE (param_values + 2) == G_TYPE_INT)
     detail2 = g_value_get_int (param_values + 2);
   
-  spi_atk_emit_eventv (gobject, detail1, detail2, "object:%s", name);
+  if (detail)
+    spi_atk_emit_eventv (gobject, detail1, detail2, "object:%s:%s", name, 
detail);
+  else
+    spi_atk_emit_eventv (gobject, detail1, detail2, "object:%s", name);
 
   return TRUE;
 }
-
-
 
 static gboolean
 spi_atk_bridge_window_event_listener (GSignalInvocationHint *signal_hint,
cvs server: Diffing cspi
cvs server: Diffing cspi/bonobo
cvs server: Diffing docs
cvs server: Diffing docs/reference
cvs server: Diffing docs/reference/cspi
cvs server: Diffing docs/reference/cspi/tmpl
cvs server: Diffing docs/reference/idl
cvs server: Diffing docs/reference/idl/tmpl
cvs server: Diffing idl
cvs server: Diffing libspi
cvs server: Diffing po
cvs server: Diffing registryd
cvs server: Diffing test
cvs server: Diffing util