RE: [g-a-devel]Top level windows

["Padraig O'Briain" <Padraig Obriain Sun COM>]

Mukund,

Yes, it does.

If a show signal is emitted for a GtkWindow, and the  GtkWindow contains a 
GtkMrnu which is attached to a menu item, we do not report it as a toplevel.

> Padraig,
> 
> >
> >  Proposed patch attached.
> >
> 
> Quick clarification - Does this patch also address the problem I
> mentioned ?
> 
> Cheers,
> Mukund.
> 
> 
> >  >
> >  > Padraig,
> >  >
> >  > Firstly, confirming if we are on the same page with
> >  regards to this
> >  > problem -
> >  >
> >  > When I choose an option from the menu bar, the menu items
> >  under that
> >  > option get exposed as separate windows (role = frame)
> >  subsequently.
> >  > That is, once selected, the menu-items along with the menu gets
> >  > reported as frames even though they are not visible.
> >  >
> >  > I am pasting the output for eog using my text tool -
> >  >
> >  > -- output --
> >  >
> >  > |- eog : invalid : |- Eye of Gnome : frame : Co:
> >  >    |- null : panel : Co:
> >  >       |- null : panel : Co:
> >  >          |- null : panel : Co:
> >  >             |- grip : separator : Ac:Co:
> >  >             |- null : menu-bar : Co:Se:
> >  >                |- File : menu : Ac:Co:
> >  >                   |- null : menu : Co:Se:  <---
> >  >                      |- New Window : menu-item : Ac:Co:
> >  >                      |- null : menu-item : Ac:Co:
> >  >                      |- Open... : menu-item : Ac:Co:
> >  >                      |- null : menu-item : Ac:Co:
> >  >                      |- null : menu-item : Ac:Co:
> >  >                      |- Close : menu-item : Ac:Co:
> >  >                      |- Exit : menu-item : Ac:Co:
> >  >                |- View : menu : Ac:Co:
> >  >                   |- null : menu : Co:Se:
> >  >                      |- null : menu-item : Ac:Co:
> >  >                      |- null : menu-item : Ac:Co:
> >  >                |- Settings : menu : Ac:Co:
> >  >                      |- Preferences : menu-item : Ac:Co:
> >  >                |- Help : menu : Ac:Co:
> >  >                   |- null : menu : Co:Se:
> >  >                      |- About... : menu-item : Ac:Co:
> >  >       |- null : panel : Co:
> >  >          |- null : panel : Co:
> >  >             |- grip : separator : Ac:Co:
> >  >             |- null : panel : Co:
> >  >                |- null : panel : Co:
> >  >                   |- Open : push-button : Ac:Co:Im:
> >  >                |- null : panel : Co:
> >  >                   |- Close : push-button : Ac:Co:Im:
> >  >                |- null : panel : Co:
> >  >                   |- null : toggle-button : Ac:Co:Im:
> >  >       |- null : filler : Co:
> >  >          |- null : filler : Co:
> >  >             |- null : filler : Co:
> >  >                |- null : filler : Co:
> >  >                   |- null : panel : Co:
> >  >                      |- null : label : Co:Tx:
> >  >          |- null : filler : Co:
> >  > |- null : frame : Co:   <---- AGAIN REPORTED!!
> >  >    |- null : menu : Co:Se:
> >  >       |- New Window : menu-item : Ac:Co:
> >  >       |- null : menu-item : Ac:Co:
> >  >       |- Open... : menu-item : Ac:Co:
> >  >       |- null : menu-item : Ac:Co:
> >  >       |- null : menu-item : Ac:Co:
> >  >       |- Close : menu-item : Ac:Co:
> >  >       |- Exit : menu-item : Ac:Co:
> >  > Finished querying children
> >  >
> >  > -- End of output --
> >  >
> >  > I initially thought it was some problem with my tool but at-poke
> >  > reports the frame too (when it's not visible).
> >  >
> >  > Is this what you are referring to ? If so, it would be
> >  desirable not
> >  > to exporting them as separate windows (frames).
> >  >
> >  > Cheers,
> >  > Mukund.
> >  >
> >  >
> >  > >
> >  > >  While sniffing about at the panel I noticed that there
> >  are a  lot
> >  > > of GtkWindows  created during startup which are associated with
> >  > > menus and  which are not
> >  > >  visible. I assume that these should not be reported as
> >  > >  existing, i.e.
> >  > >  gail_toplevel_object_init() should check whether
> >  > >  GTK_WIDGET_VISIBLE is set for a
> >  > >  GtkWindow and remove it from its list of toplevel windows if
> >  > >  it is not.
> >  > >
> >  > >  I will make this change if there are no objections.
> >  > >
> >  > >  Padraig
> >  > >
> >  >
> >  >
> >  > _______________________________________________
> >  > Gnome-accessibility-devel mailing list
> >  > Gnome-accessibility-devel gnome org
> >  > http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel
> >
> 
> 
> 
> begin 666 InterScan_Disclaimer.txt
> M*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BI$:7-C;&%I;65R*BHJ*BHJ*BHJ
> M*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ#0H-"DEN9F]R;6%T:6]N(&-O
> M;G1A:6YE9"!I;B!T:&ES($4M34%)3"!B96EN9R!P<F]P<FEE=&%R>2!T;R!7
> M:7!R;R!,:6UI=&5D#0II<R G<')I=FEL96=E9"<@86YD("=C;VYF:61E;G1I
> M86PG(&%N9"!I;G1E;F1E9"!F;W(@=7-E(&]N;'D 8GD@=&AE#0II;F1I=FED
> M=6%L(&]R(&5N=&ET>2!T;R!W:&EC:"!I="!I<R!A9&1R97-S960N(%EO=2!A
> M<F4@;F]T:69I960 =&AA="!A;GD-"G5S92P 8V]P>6EN9R!O<B!D:7-S96UI
> M;F%T:6]N(&]F('1H92!I;F9O<FUA=&EO;B!C;VYT86EN960@:6X =&AE($4M
> M34%)3 T*:6X 86YY(&UA;FYE<B!W:&%T<V]E=F5R(&ES('-T<FEC=&QY('!R
> M;VAI8FET960N#0H-"@T*("HJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ
> I*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ#0H 
> end
> 
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel