Re: libbonoboui uses GTK_LAYOUT's xoffset and yoffset

[Rodrigo Moya <rodrigo gnome-db org>]

On Sun, 2001-11-18 at 23:13, Rodrigo Moya wrote:
> Hi!
> 
> in libbonoboui/bonobo/bonobo-canvas-component.c:135
> 
>         GTK_LAYOUT (item->canvas)->xoffset = state->xoffset;
>         GTK_LAYOUT (item->canvas)->yoffset = state->yoffset;
> 
> and those have been removed from GtkLayout structure. So, I suppose this
> is no longer necessary, so, is it ok to commit the attached patch?
> 
sorry, this patch is incomplete, since I just found, in
bonobo/bonobo-canvas-item.c:

        target->xoffset   = GTK_LAYOUT (canvas)->xoffset;
        target->yoffset   = GTK_LAYOUT (canvas)->yoffset;

so, this does not seem too clear to be removed and not affect anything,
so how to solve this?

cheers

> ? po/po2tbl.sed
> ? po/po2tbl.sed.in
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/libbonoboui/ChangeLog,v
> retrieving revision 1.179
> diff -u -r1.179 ChangeLog
> --- ChangeLog	2001/11/15 06:40:45	1.179
> +++ ChangeLog	2001/11/18 22:19:23
> @@ -1,3 +1,8 @@
> +2001-11-18  Rodrigo Moya <rodrigo gnome-db org>
> +
> +	* bonobo/bonobo-canvas-component.c (restore_state): don't set
> +	GtkLayout's xoffset and yoffset, which no longer exist
> +
>  2001-11-15  Michael Meeks  <michael ximian com>
>  
>  	* tests/control/test-control.c (run_tests): beef up
> Index: bonobo/bonobo-canvas-component.c
> ===================================================================
> RCS file: /cvs/gnome/libbonoboui/bonobo/bonobo-canvas-component.c,v
> retrieving revision 1.42
> diff -u -r1.42 bonobo-canvas-component.c
> --- bonobo/bonobo-canvas-component.c	2001/11/04 23:09:31	1.42
> +++ bonobo/bonobo-canvas-component.c	2001/11/18 22:19:23
> @@ -132,8 +132,6 @@
>  	item->canvas->scroll_y1 = state->canvas_scroll_y1;
>  	item->canvas->zoom_xofs = state->zoom_xofs;
>  	item->canvas->zoom_yofs = state->zoom_yofs;
> -	GTK_LAYOUT (item->canvas)->xoffset = state->xoffset;
> -	GTK_LAYOUT (item->canvas)->yoffset = state->yoffset;
>  }
>  
>  /* This is copied from gnome-canvas.c since it is declared static */
-- 
Rodrigo Moya <rodrigo gnome-db org> - <rodrigo ximian com>
http://www.gnome-db.org/ - http://www.ximian.com/