Re: Patch to make gnome-vfs HEAD compile with GNOME 2.0 libs

[Carlos Perelló Marín <carlos gnome-db org>]

El 11 Jun 2001 08:51:16 -0700, Darin Adler escribió:
> On Monday, June 11, 2001, at 08:23  AM, Carlos Perelló Marín wrote:
> 
> > Could I commit?
> 
> Patches to gnome-vfs need to go to the gnome-vfs list, not gnome-2-0-list.
> 

Ok, sorry

> It seems like it might be OK to commit. I have two reservations:
> 
>       1) I am confused about why cdda-method.c is different from all the 
> other modules. Why is this the only file that needs to be changed?
> 

Well, as I have seen, the other modules has already those changes
applied, I don't understand why none has get this error before now :-?


>       2) We had planned to branch gnome-vfs once we had to start making 
> substantial code changes to support GNOME 2 vs. GNOME 1. Has this moment 
> arrived yet? We don't want to litter the code with preprocessor 
> conditionals.
> 

I don't know the answer to this question, I'm starting now with GNOME
2.0. Sorry.

> Once we have dealt with both of these issues, you can commit.
> 

Ok.

>      -- Darin
> 
> PS: Patch, for people on gnome-vfs mailing list who don't subscribed to 
> gnome-2-0-list:
> 
> Index: cdda-method.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/cdda-method.c,v
> retrieving revision 1.12
> diff -u -w -r1.12 cdda-method.c
> --- cdda-method.c     2001/03/16 03:34:22     1.12
> +++ cdda-method.c     2001/06/11 15:21:57
> @@ -1022,8 +1022,11 @@
>               gconf_init (1, argv, NULL);
>       }
> 
> +#if GNOME_PLATFORM_VERSION < 1095000
>       gtk_type_init();
> -     gtk_signal_init();
> +#else
> +        gtk_type_init (G_TYPE_DEBUG_NONE);
> +#endif
>       
>       return &method;
>   }
> ===================================================================
> 
> _______________________________________________
> gnome-2-0-list mailing list
> gnome-2-0-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-2-0-list

-- 
Carlos Perelló Marín
mailto:carlos gnome-db org
mailto:carlos hispalinux es
http://www.gnome-db.org
http://www.Hispalinux.es
Valencia - Spain