gnome_about_construct()

[murrayc t-online de (Murray Cumming)]

Do I have permission to commit this patch to libgnomeui, adding the
gnome_about_construct() function which was present in gnome-libs
1.2.x/1.4.x?

I know that it should use properties instead, but I don't see the point
as long as that's not going to happen across the rest of libgnomeui, and
this is very easy to do.

-- 
Murray Cumming
murrayc usa net
www.murrayc.com

? libgnomeui.kdevprj
? libgnomeui.kdevses
? gnome_about_construct.patch
Index: libgnomeui/gnome-about.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-about.c,v
retrieving revision 1.94
diff -u -u -p -r1.94 gnome-about.c
--- libgnomeui/gnome-about.c	2001/11/13 01:09:28	1.94
+++ libgnomeui/gnome-about.c	2001/12/03 22:57:08
@@ -1165,14 +1165,33 @@ gnome_about_new (const gchar  *name,
 		 GdkPixbuf    *logo_pixbuf)
 {
 	GnomeAbout *about;
-	GValueArray *authors_array;
-	GValueArray *documenters_array;
-	static GdkPixbuf *background_pixbuf = NULL;
-	gint i;
 	
 	g_return_val_if_fail (authors != NULL, NULL);
 	
 	about = g_object_new (GNOME_TYPE_ABOUT, NULL);
+        gnome_about_construct(about, 
+			      name, version, copyright, 
+			      comments, authors, documenters, 
+			      translator_credits, logo_pixbuf);
+
+	return GTK_WIDGET(about);
+}
+
+void
+gnome_about_construct (GnomeAbout *about,
+		       const gchar  *name,
+		       const gchar  *version,
+		       const gchar  *copyright,
+		       const gchar  *comments,
+		       const gchar **authors,
+		       const gchar **documenters,
+		       const gchar  *translator_credits,
+		       GdkPixbuf    *logo_pixbuf)
+{
+	GValueArray *authors_array;
+	GValueArray *documenters_array;
+	static GdkPixbuf *background_pixbuf = NULL;
+	gint i;
 
 	authors_array = g_value_array_new (0);
 	
@@ -1224,8 +1243,6 @@ gnome_about_new (const gchar  *name,
 	}
 
 	gtk_window_set_resizable (GTK_WINDOW (about), FALSE);
-	
-	return GTK_WIDGET (about);
 }
 
 static void
Index: libgnomeui/gnome-about.h
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-about.h,v
retrieving revision 1.25
diff -u -u -p -r1.25 gnome-about.h
--- libgnomeui/gnome-about.h	2001/10/23 21:56:54	1.25
+++ libgnomeui/gnome-about.h	2001/12/03 22:57:08
@@ -66,6 +66,18 @@ GtkWidget *gnome_about_new (const gchar 
 			    const gchar  *translator_credits,
 			    GdkPixbuf    *logo_pixbuf);
 
+/* Only for use by bindings to languages other than C; don't use
+   in applications. */
+void gnome_about_construct (GnomeAbout *about,
+			    const gchar  *name,
+			    const gchar  *version,
+			    const gchar  *copyright,
+			    const gchar  *comments,
+			    const gchar **authors,
+			    const gchar **documenters,
+			    const gchar  *translator_credits,
+			    GdkPixbuf    *logo_pixbuf);
+
 G_END_DECLS
 
 #endif /* __GNOME_ABOUT_H__ */