Re: [gnet-devel] [PATCH] use GLib's isspace
- From: Tim Müller <t i m zen co uk>
- To: gnet-devel-list gnome org
- Subject: Re: [gnet-devel] [PATCH] use GLib's isspace
- Date: Fri, 07 Dec 2007 13:14:16 +0000
On Wed, 2007-11-28 at 15:39 -0500, Jeff Garzik wrote:
> The comment for the locally-defined ISSPACE() macro seems to indicate
> the same purpose as g_ascii_isspace(), so I made the replacement.
> I have not, however, verified the correctness against the relevant RFCs.
> I'm hoping the code's author could give this a review...
The only difference between the custom ISSPACE and g_ascii_isspace()
seems to be the treatment of ASCII character #11, which
g_ascii_isspace() does not recognise as space. This breaks the uri unit
test. Not that the breakage looks particularly severe, but I think I'd
prefer not to change it (or use (g_ascii_isspace(*p) || *p == 11)
instead) unless there's a better rationale to it.
[Date Prev][Date Next
] [Thread Prev][Thread Next