Re: [gnet-dev] GConnHttp change

["Samuel Cormier-Iijima" <sciyoshi gmail com>]

Yup, thanks a lot :-)

On 10/30/06, Tim Müller <t i m zen co uk> wrote:
> On Sun, 2006-10-29 at 09:30 -0500, Samuel Cormier-Iijima wrote:
>
> > OK, updated patch attached. New function is
> > gnet_conn_http_set_uri_unescaped
>
> Looks good in principle, but _set_uri_unescaped() is a bit ambiguous
> IMHO (I would at first glance assume that to mean the URI you are
> passing should be unescaped, not that it is not going to be escaped).
>
> I've added this as gnet_conn_http_set_escaped_uri() now in CVS, please
> double-check that it works right:
>
>   2006-10-30  Tim-Philipp Müller  <tim at centricular dot net>
>
>         Based on patch by: Samuel Cormier-Iijima  <sciyoshi gmail com>
>
>         * NEWS:
>         * doc/gnet-sections.txt:
>         * src/conn-http.c: (gnet_conn_http_set_uri_internal),
>         (gnet_conn_http_set_uri), (gnet_conn_http_set_escaped_uri):
>         * src/conn-http.h:
>           API: added gnet_conn_http_set_escaped_uri().
>
>
> > make check passes.
>
> Not entirely surprising given that this isn't tested at all ;)
>
> Thanks for the patch.
>
>  Cheers
>   -Tim