Re: [gnet-dev] GURL patch
- From: David Helder <dhelder umich edu>
- To: David Bolcsfoldi <david bolcsfoldi telia com>
- Cc: <gnet-dev gnetlibrary org>
- Subject: Re: [gnet-dev] GURL patch
- Date: Sun, 7 Oct 2001 17:48:09 -0400 (EDT)
Looks good. I changed around the parsing some. It now parses "foo:bar"
as "scheme:path" instead of "scheme:hostname", which I think was what
yours did (and maybe mine did originally too).
I also made other improvements. Eg, the resource/path no longer has a /
prepended to it if it doesn't already start with a / in set_resource().
Also, when "\0" is passed to gnet_url_new, it does create a GURL, before
it g_return_if_failed when it couldn't find a hostname. Overall, I think
things are more sane and RFC-compliant.
Your url-test is now tests/urlparse. I also added a "make check" test
called tests/url_test.c. It tests about 15 urls. Tell me if you think
any are parsed wrong.
David
--
__ _ __ David Helder - dhelder umich edu
___/ /__ __ __(_)__/ / <http://www.eecs.umich.edu/~dhelder>
/ _ / _ `/ |/ / / _ / Jungle Monkey: <http://www.junglemonkey.net>
|_,_/|_,_/|___/_/|_,_/ Paper CD Case: <http://www.papercdcase.com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]