[gdome] gtk-doc install bug in Makefile.am

[Richard Bos <radoeka xs4all nl>]

While building a gdome2 rpm as regular user, I get the following error:

make[2]: Nothing to be done for `install-exec-am'.
install -d -m 0755 /usr/share/gtk-doc/html/gdome2-0.8.1
install: cannot create directory `/usr/share/gtk-doc': Permission denied
make[2]: [install-data-local] Error 1 (ignored)
install -m 0644 ./html/*.html /usr/share/gtk-doc/html/gdome2-0.8.1
install: installing multiple files, but last argument, 
`/usr/share/gtk-doc/html/gdome2-0.8.1' is not a directory
Try `install --help' for more information.
make[2]: [install-data-local] Error 1 (ignored)
install -m 0644 ./html/index.sgml /usr/share/gtk-doc/html/gdome2-0.8.1
install: cannot create regular file `/usr/share/gtk-doc/html/gdome2-0.8.1': No 
such file or directory
make[2]: [install-data-local] Error 1 (ignored)
(cd /tmp/gdome2-root; gtkdoc-fixxref --module=gdome2-0.8.1 
--html-dir=/usr/share/gtk-doc/html)
Can't open HTML directory /usr/share/gtk-doc/html/gdome2-0.8.1: No such file 
or directory at /opt/gnome/bin/gtkdoc-fixxref line 109.
make[2]: [install-data-local] Error 2 (ignored)
make[2]: Leaving directory `/home/richard/packages/BUILD/gdome2-0.8.1/gtk-doc'

The responsible part of the Makefile is:
Makefile.am
------------
HTML_DIR= HTML_DIR@

TARGET_DIR=$(HTML_DIR)/$(DOC_MODULE)

...skip....

install-data-local:
        -install -d -m 0755 $(TARGET_DIR)
        -install -m 0644 $(srcdir)/html/*.html $(TARGET_DIR)
        -install -m 0644 $(srcdir)/html/index.sgml $(TARGET_DIR)
        -(cd $(DESTDIR); gtkdoc-fixxref --module=$(DOC_MODULE) 
--html-dir=$(HTML_DIR))

I changed this in the Makefile.in to:
install-data-local:
        -install -d -m 0755 $(DESTDIR)/$(TARGET_DIR)
        -install -m 0644 $(srcdir)/html/*.html $(DESTDIR)/$(TARGET_DIR)
        -install -m 0644 $(srcdir)/html/index.sgml $(DESTDIR)/$(TARGET_DIR)
        -(cd $(DESTDIR); gtkdoc-fixxref --module=$(DOC_MODULE) 
--html-dir=$(DESTDIR)/$(HTML_DIR))

(adding $(DESTDIR)) and now no install error is reported.

Resulting in:
make[1]: Entering directory 
`/home/richard/packages/BUILD/gdome2-0.8.1/gtk-doc'
make[2]: Entering directory 
`/home/richard/packages/BUILD/gdome2-0.8.1/gtk-doc'
make[2]: Nothing to be done for `install-exec-am'.
install -d -m 0755 /tmp/gdome2-root//usr/share/gtk-doc/html/gdome2-0.8.1
install -m 
0644 ./html/*.html /tmp/gdome2-root//usr/share/gtk-doc/html/gdome2-0.8.1
install -m 
0644 ./html/index.sgml /tmp/gdome2-root//usr/share/gtk-doc/html/gdome2-0.8.1
(cd /tmp/gdome2-root; gtkdoc-fixxref --module=gdome2-0.8.1 
--html-dir=/tmp/gdome2-root//usr/share/gtk-doc/html)

Which seems okay.

-- 
Richard Bos
Without a home the journey is endless