Re: [gdm-list] [PATCH] 64bit compilation and gnome-screensaver
- From: Rodrigo Moya <rodrigo novell com>
- To: Brian Cameron <Brian Cameron Sun COM>
- Cc: gdm-list gnome org
- Subject: Re: [gdm-list] [PATCH] 64bit compilation and gnome-screensaver
- Date: Sat, 24 Sep 2005 00:45:15 +0200
On Fri, 2005-09-23 at 11:39 -0500, Brian Cameron wrote:
> Rodrigo:
>
> > Two patches attached, first one (in gdmphotosetup.c) is for fixing
> > warnings and errors on 64bit compilation.
> >
> > The second one has been in my tree for some time now, not sure if I
> > already sent it, but seems not, so sending it here. It just makes use of
> > gnome-screensaver instead of xscreensaver if available.
> >
> > Ok to commit?
>
> It's okay to commit.
>
ok, committed to HEAD
> Really, though, I'd prefer if people could
> specify the screensaver in the gdm.conf file rather than hardcoding
> the name of the program in the code. The configure file could
> check to see if gnome-screensaver is on the system and set it to
> that. If not, then it could check if xscreensaver is on the
> system and set it to that. If neither, it could leave it blank.
> This would be more usable, I think.
>
the problem with that approach is that you might have xscreensaver only
installed in the system at configure time, then install
gnome-screensaver, and not be able to use it unless you recompile.
Not sure if that's a big problem, but since all other gnome modules that
use the screensaver do it this way, I thought this would be ok for gdm
also.
--
Rodrigo Moya <rodrigo novell com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]