Re: [PATCH] GDM-2.4.4.3 Display optional info message before login

[George <jirka 5z com>]

On Wed, Oct 01, 2003 at 10:04:10AM +0100, Anton Altaparmakov wrote:
> Dear George,
> 
> The below patch for gdm-2.4.4.3 adds a gdm.conf option
> daemon/GdmInfoMsgFile= which if present and pointing to a file (e.g.
> GdmInfoMsgFile=/etc/infotextfile) will be displayed in a modal dialog box
> (which only has an "OK" button) before the user is prompted to log in.
> 
> I have implemented it both for the old gdmlogin and the new gdm greeter.
> 
> For the gdm greeter the format of the message is themable, e.g. in
> Circles.xml one would add:
> 
> diff -urNp gdm-2.4.4.3.old/gui/greeter/themes/circles/circles.xml gdm-2.4.4.3/gui/greeter/themes/circles/circles.xml
> --- gdm-2.4.4.3.old/gui/greeter/themes/circles/circles.xml	2003-09-30 15:28:59.000000000 +0100
> +++ gdm-2.4.4.3/gui/greeter/themes/circles/circles.xml	2003-09-30 17:59:14.000000000 +0100
> @@ -185,6 +185,11 @@
>        </item>
>      </fixed>
>    </item>
> +
> +  <item type="label" id="info-msg-dialog-format">
> +    <normal color="#000000" font="Sans 24"/>
> +      <text></text>
> +  </item>
>  </greeter>
> 
> To get black text with a Sans 24 font.

I'm not sure I truly like this path to customizing the font and color there.
We're not really talking about an "item" in the theme, so it really seems
like an utter hack.  What could really happen is for the file to use pango
markup optionally (or maybe just always use it, I don't think pango markup is
dangerous in any way).  This way you could not only specify a font for the
whole thing, but you could change how certain parts of it look etc...  I
suppose for any sort of "usage rules" it would be useful to make certain
parts larger and bold :)

Other than that the patch looks good.  Can you file it in bugzilla so that it
doesn't get forgotten?

George

-- 
George <jirka 5z com>
   History teaches us that men and nations behave wisely
   once they have exhausted all other alternatives.
                       -- Abba Eban, 1970