Re: building firefox: revisited once more ...

["Joseph E. Sacco, PhD" <joseph_sacco comcast net>]

Agreed on the sed magic...

The space is a good idea. It is far too easy to damage other sections of
of the FLAGS.

-Joseph


=====================================================================
On Sat, 2005-07-09 at 22:45 +0200, guenther wrote:
> On Sat, 2005-07-09 at 16:18 -0400, Joseph E. Sacco, PhD wrote:
> > firefox-1.04 does not run when built within the unstable GARNOME
> > environment where:
> > 
> >         # For Unstable GARNOME, things are assumed to be heavily broken
> >         CONFIGURE_ARGS += --enable-debug --enable-tests
> >         CFLAGS += -g
> >         CXXFLAGS += -g
> > 
> > One artifact is a version of libmozjs.so that is both huge, and broken.
> 
> Good catch, Joseph. :-)
> 
> 
> [...]
> > Anyway... I took another run at it. This time I used sed magic to
> > clobber *all* of the unstable GARNOME settings. That worked. See the
> > attached Makefile. 
> 
> > # unstable release test/debug args don't work
> > CONFIGURE_ARGS := $(shell echo $(CONFIGURE_ARGS) | sed 's,--enable-debug,--disable-debug,')
> > CONFIGURE_ARGS := $(shell echo $(CONFIGURE_ARGS) | sed 's,--enable-test,--disable-test,')
> > CFLAGS := $(shell echo $(CFLAGS) | sed 's,-g,,')
> > CXXFLAGS := $(shell echo $(CXXFLAGS) | sed 's,-g,,')
> 
> Nitpicking, but we definitely need to make that substitution more safe.
> Rather than s/-g// it must at least be s/-g // (with an additional space
> after -g), to prevent accidentally substituting the wrong part. Like a
> GARNOME build tree in /data/unstable-garnome/ and an user who tweaked
> his CFLAGS or CXXFLAGS settings...
> 
> Maybe even a word-bounding before -g?
> 
> ...guenther
> 
> 
> -- 
> char *t="\10pse\0r\0dtu\0  ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
> main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
> (c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}
> 
-- 
joseph_sacco [at] comcast [dot] net