firefox/mozilla script foo...

["Joseph E. Sacco, PhD" <joseph_sacco comcast net>]

Some of the shell script foo used in the GARNOME Makefiles is incorrect:

[ignore the line wrap]

        CONFIGURE_ARGS += $(shell if test -e "`ls $(shell echo
        $(PKG_CONFIG_PATH) | sed -e "s/:/ /g") 2>&1 /dev/null | grep
        firefox-gtkmozembed.pc`" ; then echo "--with-mozilla=firefox" ;
        fi )

should be

        CONFIGURE_ARGS += $(shell if test "`ls $(shell echo
        $(PKG_CONFIG_PATH) | sed -e "s/:/ /g") 2>&1 /dev/null | grep
        firefox-gtkmozembed.pc`" ; then echo "--with-mozilla=firefox" ;
        fi )


Applications affected: 
* epiphany
lucked out... autodetect starts with firefox

* liferea 
missing the required firefox/mozilla script foo entirely

* totem
lucked out ... looked for firefox first.

Explanation
-----------
The "-e" argument tests for the existence of a file. This test will
always fail because the "ls" part of the script returns *relative* path
names rather full path names.

The corrected version tests that the string returned by grep is not
NULL. Grep returns only the lines that match the search pattern. So, if
grep finds firefox-gtkmozembed.pc, it will return a string that is not
NULL. This is sufficient to demonstrate that firefox-gtkmozembed.pc
exists.


-Joseph


-- 
joseph_sacco [at] comcast [dot] net