Re: libcroco compile error

[Jens Bech Madsen <jbm oncable dk>]

On Mon, 2003-09-29 at 08:32, menno wrote:
> Hi,
> I'm trying to build garnome0.27.1 on a debian system.
> I get these errors:
> ###################################################################################
> make[3]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco'
> [===== NOW BUILDING:    libcroco-0.3.0  =====]
>         [fetch] complete for libcroco.
>         [checksum] complete for libcroco.
>         [extract] complete for libcroco.
>         [patch] complete for libcroco.
>         [configure] complete for libcroco.
>  ==> Running make in work/main.d/libcroco-0.3.0
> make[4]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0'
> make  all-recursive
> make[5]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0'
> Making all in src
> make[6]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src'
> Making all in parser
> make[7]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src/parser'
> make[7]: Nothing to be done for `all'.
> make[7]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src/parser'
> Making all in seleng
> make[7]: Entering directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src/seleng'
> /bin/sh ../../libtool --mode=compile cc -DHAVE_CONFIG_H -I. -I. -I../.. 
> -I../.. -I../../src/parser -I../../intl -I/root/garnome/include/glib-2.0 
> -I/root/garnome/lib/glib-2.0/include   -I/root/garnome/include/libxml2   
> -I/root/garnome/include/pango-1.0 -I/root/garnome/include/glib-2.0 
> -I/root/garnome/lib/glib-2.0/include    -I/root/garnome/include 
> -I/usr/X11R6/include  -g -I/root/garnome/include -I/usr/X11R6/include 
> -L/root/garnome/lib -L/usr/X11R6/lib -O2 -pipe -Wall -c cr-sel-eng.c
> cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../../src/parser -I../../intl 
> -I/root/garnome/include/glib-2.0 -I/root/garnome/lib/glib-2.0/include 
> -I/root/garnome/include/libxml2 -I/root/garnome/include/pango-1.0 
> -I/root/garnome/include/glib-2.0 -I/root/garnome/lib/glib-2.0/include 
> -I/root/garnome/include -I/usr/X11R6/include -g -I/root/garnome/include 
> -I/usr/X11R6/include -L/root/garnome/lib -L/usr/X11R6/lib -O2 -pipe -Wall -c 
> cr-sel-eng.c  -fPIC -DPIC -o cr-sel-eng.lo
> cr-sel-eng.c: In function `id_add_sel_matches_node':
> cr-sel-eng.c:139: parse error before `result'
> cr-sel-eng.c:148: `id' undeclared (first use in this function)
> cr-sel-eng.c:148: (Each undeclared identifier is reported only once
> cr-sel-eng.c:148: for each function it appears in.)
> cr-sel-eng.c:152: `result' undeclared (first use in this function)
> cr-sel-eng.c:162: warning: control reaches end of non-void function
> cr-sel-eng.c: In function `put_css_properties_in_hashtable':
> cr-sel-eng.c:792: parse error before `*'
> cr-sel-eng.c:801: `decl' undeclared (first use in this function)
> make[7]: *** [cr-sel-eng.lo] Error 1
> make[7]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src/seleng'
> make[6]: *** [all-recursive] Error 1
> make[6]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0/src'
> make[5]: *** [all-recursive] Error 1
> make[5]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0'
> make[4]: *** [all-recursive-am] Error 2
> make[4]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco/work/main.d/libcroco-0.3.0'
> make[3]: *** [build-work/main.d/libcroco-0.3.0/Makefile] Error 2
> make[3]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/libcroco'
> make[2]: *** [../../gnome/libcroco/cookies/main.d/install] Error 2
> make[2]: Leaving directory 
> `/root/downloads/garnome/garnome-0.27.1/gnome/librsvg'
> make[1]: *** [../../gnome/librsvg/cookies/main.d/install] Error 2
> make[1]: Leaving directory `/root/downloads/garnome/garnome-0.27.1/gnome/eog'
> make: *** [../../gnome/eog/cookies/main.d/install] Error 2
> ###########################################################################
> 
> I got some other errors i could easily correct ,but here i really don't know 
> what to do.So any suggestions are welcome.
> thanks in advance.
>                             Menno van Hoeke 

The attached patch fixes this.


/Jens

--- libcroco-0.3.0/src/seleng/cr-sel-eng.c~	Sun Jun 29 17:49:40 2003
+++ libcroco-0.3.0/src/seleng/cr-sel-eng.c	Thu Sep 18 21:42:59 2003
@@ -130,14 +130,14 @@
 id_add_sel_matches_node (CRAdditionalSel *a_add_sel,
                          xmlNode *a_node)
 {
+        xmlChar *id = NULL ;
+        gboolean result = FALSE ;
         g_return_val_if_fail (a_add_sel 
                               && a_add_sel->type == ID_ADD_SELECTOR
                               && a_add_sel->content.id_name
                               && a_add_sel->content.id_name->str
                               && a_node, FALSE) ;
 
-        gboolean result = FALSE ;
-        xmlChar *id = NULL ;
 
         g_return_val_if_fail (a_add_sel
                               && a_add_sel->type == ID_ADD_SELECTOR
@@ -786,10 +786,10 @@
         for (cur_decl = a_stmt->kind.ruleset->decl_list ; 
              cur_decl ; cur_decl = cur_decl->next)
         {
+                CRDeclaration *decl = NULL ;
+
                 if (!cur_decl->property || !cur_decl->property->str)
                         continue ;
-
-                CRDeclaration *decl = NULL ;
 
                 /*
                  *First, test if the property is not
--- libcroco-0.3.0/src/layeng/cr-lay-eng.c~	Sat Jul  5 23:08:56 2003
+++ libcroco-0.3.0/src/layeng/cr-lay-eng.c	Thu Sep 18 21:45:39 2003
@@ -1214,11 +1214,12 @@
                   CRBox *a_cur_box)
 {
         enum CRStatus status = CR_OK ;
+        CRBox *cont_box = NULL;
 
         g_return_val_if_fail (a_cur_box && a_cur_box->style,
                               CR_BAD_PARAM_ERROR) ;
         
-        CRBox *cont_box = a_cur_box->parent ;
+        cont_box = a_cur_box->parent ;
 
         /************************************
          *We are in a block formating context