Re: error building gtksourceview

["Per-Erik Westerberg (EAB)" <Per-Erik Westerberg uab ericsson se>]

Is it not bad programming to define variable types within the code 
instead of at the beginning of the function? Should not bugs be filed 
for these "faults"?

  BR / Per-Erik

On 03-05-13 08:57, Kris Luyten wrote:
> On Tue, 2003-05-13 at 07:13, Rodd Clarkson wrote:
>
> > I get the following trying to build gtksourceview-0.2.0 on redhat-7.3.
> >
> > gtksourcebuffer.c: In function `get_tags_func':
> > gtksourcebuffer.c:691: parse error before `*'
> > gtksourcebuffer.c:695: `list' undeclared (first use in this function)
> > gtksourcebuffer.c:695: (Each undeclared identifier is reported only once
> > gtksourcebuffer.c:695: for each function it appears in.)
> > make[7]: *** [gtksourcebuffer.lo] Error 1
> > make[7]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview/work/main.d/gtksourceview-0.2.0/gtksourceview'
> > make[6]: *** [all-recursive] Error 1
> > make[6]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview/work/main.d/gtksourceview-0.2.0/gtksourceview'
> > make[5]: *** [all] Error 2
> > make[5]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview/work/main.d/gtksourceview-0.2.0/gtksourceview'
> > make[4]: *** [all-recursive] Error 1
> > make[4]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview/work/main.d/gtksourceview-0.2.0'
> > make[3]: *** [all] Error 2
> > make[3]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview/work/main.d/gtksourceview-0.2.0'
> > make[2]: *** [build-work/main.d/gtksourceview-0.2.0/Makefile] Error 2
> > make[2]: Leaving directory
> > `/home/rodd/garnome-0.24.2/gnome/gtksourceview'
> > make[1]: *** [../../gnome/gtksourceview/cookies/main.d/install] Error 2
> > make[1]: Leaving directory `/home/rodd/garnome-0.24.2/gnome/gedit'
> > make: *** [../../gnome/gedit/cookies/main.d/install] Error 2
> >
> >
> > Hope someone can shed some light
>
>
> Change the following in gtksourcebuffer.c:
> ------
>
> static void
> get_tags_func (GtkTextTag *tag, gpointer data)
> {
> 	g_return_if_fail (data != NULL);
>
> 	GSList **list = (GSList **) data;
>
> 	if (GTK_IS_SOURCE_TAG (tag))
> 	{
> 		*list = g_slist_prepend (*list, tag);
> 	}
> }
>
>
> ------
>
> into 
> ------
>
> static void
> get_tags_func (GtkTextTag *tag, gpointer data)
> {
> 	GSList **list; 
> 	g_return_if_fail (data != NULL);
>
> 	list = (GSList **) data;
>
> 	if (GTK_IS_SOURCE_TAG (tag))
> 	{
> 		*list = g_slist_prepend (*list, tag);
> 	}
> }
>
>
> ------
>
> Cfr. a previous thread concerning "compiling control-center".
>
> Cheers,
> Kris
>