[gamin] Re: gam_node.c cleanup

[Daniel Veillard <veillard redhat com>]

On Mon, Jun 13, 2005 at 03:14:27PM +0100, Neal H. Walfield wrote:
> > /**
> >  * functionname:
> 
> Just to be clean: you want to repeat the name of the function?

  yes

> >  * @arg1: ...
> >  * @argn: ...
> >  *
> >  * Description of the function
> >  *
> >  * Returns description of the return value if non void
> 
> Shouldn't this be @returns ...

  no, gtk-doc style documentation

> >   I don't know what do to with your current patch, there are good points
> > but I don't feel like commiting if it breaks make tests. Until either of us
> > get to fix the breakage, I don't think the asserts should be
> > commited.
> 
> Okay now?

  yes, both are commited, thanks ! :-)

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/