Re: [gamin] gamin-lose-watch-fix.patch

[John McCutchan <ttb tentacle dhs org>]

On Thu, 2005-07-28 at 11:38 -0400, Daniel Veillard wrote:
> On Thu, Jul 28, 2005 at 11:33:26AM -0400, John McCutchan wrote:
> > On Thu, 2005-07-28 at 10:21 -0400, Daniel Veillard wrote:
> > Once I commit this patch, you can close a bunch of Fedora bugs about
> > 'events not being sent after awhile.' and those gnome bugs.
> 
>   yes, very cool, but I would have to push a new version first :-)
> 
> > > > The patch also includes some debug changes, and I factored out the get
> > > > pid name code. I'm away from my main development machine, so I won't be
> > > > able to commit this until Sunday. Feel free to commit before then.
> > > 
> > >    I'm not sure why some messages were removed and other were added,
> > > but this looks cosmetic. I'm a bit surprized by the memset for the stat
> > > buffer, I would expect the kernel to fill out the bits, but this should
> > > be safe. So yes, sure, commit !
> > 
> > 
> > The debug messages are mainly cosmetic, and I tried to cut down on some
> > messages that I didn't find helpful. I only added those memset bits to
> > keep valgrind happy...
> 
>   haha, I didn't see any reply to you mail for valgrind, did it got accepted ?
> I need to check the subversion version, to be sure.

Yep it went in on Monday.

John