Re: [gamin] gamin-lose-watch-fix.patch

[John McCutchan <ttb tentacle dhs org>]

Daniel, can you take a look at this?

On Mon, 2005-07-25 at 18:52 -0400, John McCutchan wrote:
> Yo,
> 
> I'm attaching a patch that fixes the reference counting bugs
> http://bugzilla.gnome.org/show_bug.cgi?id=172365 ,
> http://bugzilla.gnome.org/show_bug.cgi?id=302236 , and countless distro
> specific bug reports.
> 
> The bug symptom was that the kernel backends would drop the refcount to
> 0 and then stop watching a directory, while the subscription layer would
> think that it was still watching the directory. 
> 
> The cause of the bug was a missing return statement when removing a
> subscription that was on the new subscription list. Gamin would ask the
> kernel to stop watching a directory when it had never asked it to watch
> it in the first place (because it was still on the new queue). This
> caused the kernel ref counting to screw up. This was also why that
> assert was causing a crash for me.
> 
> The patch also includes some debug changes, and I factored out the get
> pid name code. I'm away from my main development machine, so I won't be
> able to commit this until Sunday. Feel free to commit before then.
> 
> John McCutchan
> _______________________________________________
> Gamin-list mailing list
> Gamin-list gnome org
> http://mail.gnome.org/mailman/listinfo/gamin-list