Re: [gamin] a couple patches needing review

From: Daniel Veillard <veillard redhat com>
To: John McCutchan <ttb tentacle dhs org>
Cc: gamin-list gnome org
Subject: Re: [gamin] a couple patches needing review
Date: Thu, 21 Jul 2005 13:58:56 -0400

On Thu, Jul 21, 2005 at 01:27:11PM -0400, John McCutchan wrote:
> Yo Daniel, I'd like you to review the 2 patches attached.
> 
> pidname-patch: Same thing posted before. Just want to get your okay.
> gamin-poll.patch: moves some poll debug under GAM_VERBOSE_POLL ifdef's.

  fp = fopen(procname, "r");  <- that descriptor is leaked, fix first :-)
otherwise okay, is the node->checks change related to the flow control problem ?

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

References:
- [gamin] a couple patches needing review
  - From: John McCutchan

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]