Re: [gamin] a couple patches needing review

On Thu, Jul 21, 2005 at 01:27:11PM -0400, John McCutchan wrote:
> Yo Daniel, I'd like you to review the 2 patches attached.
> pidname-patch: Same thing posted before. Just want to get your okay.
> gamin-poll.patch: moves some poll debug under GAM_VERBOSE_POLL ifdef's.

  fp = fopen(procname, "r");  <- that descriptor is leaked, fix first :-)
otherwise okay, is the node->checks change related to the flow control problem ?


Daniel Veillard      | Red Hat Desktop team
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]