Re: [gamin] support for inotify 0.18 take 2

[John McCutchan <ttb tentacle dhs org>]

On Sun, 2005-01-30 at 09:20 +1100, Jeff Waugh wrote:
> <quote who="John McCutchan">
> 
> > On Sat, 2005-01-29 at 10:21 +1100, Jeff Waugh wrote:
> > > <quote who="John McCutchan">
> > > 
> > > > my previous patch had some problems, it was leaking lots of memory.
> > > > This is an updated version of my previous patch, that fixes the new
> > > > leaks, and fixes an old leak that was around from the beginning.
> > > 
> > > Hi John,
> > > 
> > > The previous patch seemed to kill gam_server, resulting in it respawning
> > > in rapid and surprising ways... This patch doesn't do that, but it
> > > doesn't seem to provide notifications, either. Only one of the gamin
> > > tests pass. ;-) If I can help with debug/strace logs or whatever, please
> > > let me know.
> > 
> > Attached is the fix. 
> 
> Works like a charm, thanks very much for your help. [ btw, Ubuntu is now
> fully inotify 0.18 enabled! It rocks way too hard. :-) ]
> 

That's excellent!!

> > gamin using inotify won't pass the test suite because the inotify backend
> > doesn't also use the poll backend like the dnotify backend does.
> 
> Aha! Meanwhile, I was poking fun at Daniel for not running his test suite.
> ;-) [ Turns out he's not using inotify at all yet, but we'll fix that soon
> enough. ]

Yes, a friend of mine will be building Fedora RPMs soon. Maybe Daniel
will run one of those :)


-- 
John McCutchan <ttb tentacle dhs org>