[ISSUE] games-network is plain wrong

["Daniel S. Haischt" <me daniel stefan haischt name>]

Hello,

today I debugged games-network.c a little further and
hence I am going to start a somewhat provoking thread.

This is my use case ...

 1) I did start a server game which will be announced
    via Zeroconf.

 2) Afterwards I do try to connect to that particular
    game with another (gnibbles) client.

The issue starts in network_connect when the client
starts to connect to a server...

 1) here you are calling getaddrinfo() where the server
    name is set to gnothello.gnome.org. Actually dig
    tells me that this server does not exist. Thus I am
    getting a -2 return value (i.e. EAI_NONAME - Name
    or Service is unknown).

Cause I do want to connect to a LAN game I tried to
figure out why you were using a WAN server name (it
should be set to localhost or something).

In games-network-dialog.c (connect_cb()) you are setting
up the LAN game. Here lan_server is set to the name that
was resolved using Zeroconf. But now comes the missconception
as I see it ...

At the very end of connect_cb() you are calling
games_network_connect() if the client is in JOIN_LAN_MODE
which is the case. Here u are using 'server' as a server
name which is gain set to gnothello.gnome.org. Finally
you are calling games_network_connect() using 'server'
as a servername. Why are you ding this if it is a LAN game?

Shouldn't you use lan_server as a servername?

-- 
Mit freundlichen Gruessen / With kind regards
DAn.I.El S. Haischt

Spammers, please please send any mail to:
Daniel S. Haischt <me_c daniel stefan haischt name>

Want a complete signature??? Type at a shell prompt:
$ > finger -l haischt daniel stefan haischt name