Picasa web patch - Small review



http://bugzilla.gnome.org/show_bug.cgi?id=344851

Posting it here in the mailing list as well.

First impressions... Cool :)

First check. Used the wrong account name (forgot the @google.com) and got the
following in the console

System.Net.WebException: Error getting response stream (ReadDone2):
ReceiveFailure ---> System.Exception:
at System.Net.WebConnection.HandleError ()
at System.Net.WebConnection.ReadDone ()
at System.MulticastDelegate.invoke_void_IAsyncResult ()
in <0x000ad> System.Net.WebConnection:HandleError (WebExceptionStatus st,
System.Exception e, System.String where)--- End of inner exception stack trace
---

in <0x00158> System.Net.HttpWebRequest:EndGetResponse (IAsyncResult
asyncResult)
in <0x00047> System.Net.HttpWebRequest:GetResponse ()
in <0x003f9> Mono.Google.Authentication:GetCookieContainer (System.String user,
System.String password)
in <0x00054> Mono.Google.Authentication:GetAuthCookies ( System.String user,
System.String password, GoogleService service)
in <0x0002f> Mono.Google.GoogleConnection:Authenticate (System.String user,
System.String password)
in <0x00064> FSpot.GoogleAccount:Connect ()
in <0x000c9> FSpot.GoogleExport:Connect (FSpot.GoogleAccount selected)


I then fixed my userid and managed to connect, and started to upload a photo.
Nothing seemed to happend. Just hanging there... Apparently, it was a large
file (original size) 3 MB. Would be nice with an indication that something is
happening.

Console states "Started Upload" Upload to what? If this text should be there,
perhaps change to "Started Upload to Picasaweb"

I also ticked the "Open album in browser when done uploading" but nothing
happend in my firefox session. (Apparently commented out in the code!)

No tooltips in the gui

LoadPreference has no default switch statement.

In all, the code do look very nice and clean, easy to follow. Very good job.
Will continue to check the code and test a bit more later...

/Bengt


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]