Re: browse/edit toggle button patch

[John Russell <jjrussell gmail com>]

Or "I see your checkin", whichever makes more sense...
On 11/30/05, John Russell <jjrussell gmail com> wrote:
> I see you checking.  Check out the attached patch for getting rid of
> those double sounds?
>
> Also, you removed some additional code from the HandleToggleView*
> methods.  Is there really any reason to have both those and the
> HandleView* methods immediately below them?  I believe that the
> versions of the HandleToggleView* methods in this patch could be used
> for HandleView* methods are in all circumstances.
>
> Also, I don't think those HandleView* methods are actually used
> anywhere so they should probably be removed anyway.  Better yet,
> rename HandleToggleView* to HandleView*.
> I didn't rename them in the patch, just babbling.
>
> Any thoughts?
>
> John
>
> On 11/30/05, Gabriel Burt <gabriel burt gmail com> wrote:
> > On Tue, 2005-11-29 at 23:27 -0500, John Russell wrote:
> > > The Browse/Edit toggle buttons have an odd behavior.  When you click
> > > the browse button it is set to active and view_mode is set to
> > > ModeType.PhotoView.  However if you click it again, the button becomes
> > > inactive.  Same thing for the Edit button.
> >
> > I've committed a modified version of your patch.  You're right that a
> > radio group would be better - I think having that would prevent the
> > double toggle sounds I'm hearing (from one turning on, the other off).
> >
> > Gabriel
> >
> >
>
>
>