Re: [evolution-patches] [Mail]Fix for bug 333243

[jeff <Jeff Cai Sun COM>]

So we should give a rule about how to deal with those critical warning 
problems.
I think there are many critical warnings exists in evolution code. How will 
we fix them?
Can we just give a check to remove those warnings or give further 
investigation for them?
If we choose the later, it means large amount of work.

----- Original Message ----- 
From: "Jeffrey Stedfast" <fejj novell com>
To: "jeff" <Jeff Cai Sun COM>
Cc: <evolution-patches gnome org>
Sent: Friday, March 03, 2006 11:28 PM
Subject: Re: [evolution-patches] [Mail]Fix for bug 333243


> No, because if the patch is committed now, the real reason for the bug
> won't be tracked down and will go unresolved for years.
>
> Jeff
>
> On Fri, 2006-03-03 at 23:20 +0800, jeff wrote:
> > Yes, you are right.
> > But I think this is a very serious bug, because if it is not fixed,
> > new user will not be able to use evolution. So I suggest to commit it 
> > first.
> > Do you think so?
> >
> > Jeff Cai.
> > ----- Original Message ----- 
> > From: "Jeffrey Stedfast" <fejj novell com>
> > To: "jeff cai" <Jeff Cai Sun COM>
> > Cc: <evolution-patches gnome org>
> > Sent: Friday, March 03, 2006 11:05 PM
> > Subject: Re: [evolution-patches] [Mail]Fix for bug 333243
> >
> >
> > >I think the more important question is how is this API getting a NULL
> > > uri?
> > >
> > > your fix may be correct, but it's still important to know WHY it is
> > > sometimes NULL first to be sure we aren't just fixing a symptom rather
> > > than the real bug.
> > >
> > > Jeff
> > >
> > > On Fri, 2006-03-03 at 21:23 +0800, jeff cai wrote:
> > >> Hi
> > >> If uri is null, don't remove it.
> > >>
> > >> Please review it.
> > >>
> > >>
> > >> _______________________________________________
> > >> Evolution-patches mailing list
> > >> Evolution-patches gnome org
> > >> http://mail.gnome.org/mailman/listinfo/evolution-patches
> > > -- 
> > > Jeffrey Stedfast
> > > Evolution Hacker - Novell, Inc.
> > > fejj ximian com  - www.novell.com
> > >
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > >
> --
> Jeffrey Stedfast
> Evolution Hacker - Novell, Inc.
> fejj ximian com  - www.novell.com
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches