Re: [evolution-patches] [Mailer] Possible fix for #333213

[Jeffrey Stedfast <fejj novell com>]

The patch is bad because callers of e_iconv() expect errno to be set on
-1 and your patch breaks that guarantee.

I would really appreciate seeing the section on iconv in the POSIX.1
specification explaining what is meant and entailed by "irreversable
conversion" and also whether this count is maintained thru multiple
calls to iconv() or not[1].

that answered, yes, probably we should be checking that the count is not
> 0 in the composer code and possibly other places in evolution as well.


1. say, for example, I call iconv() and my outbuf isn't large enough -
some conversion has still occured and it has possibly already made some
"irreversable conversions" but since iconv() will return -1, how do I
know? After making my nth call to iconv() finishing the conversion of
all the data, will the return code of iconv() be the cumulative count of
"irreversable conversions"? or only that of my last call to iconv()?

On Fri, 2006-03-03 at 12:13 +0800, simon.zheng wrote:
> Hi,
> 
> Bug 333213 – Can't specify the encoding as ISO-8859-15 in mail composer
> on Solaris.
> http://bugzilla.gnome.org/show_bug.cgi?id=333213
> 
> Attached a patch for review. 
> 
> Changing wrapper for iconv(). Translate non-zero value returned by
> iconv() to -1.
> 
> Thanks,
> -Simon
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com