Re: [evolution-patches] [Calendar] Fix for 225816

[chen <pchenthill novell com>]

Hi,
   Why do u call sensitize widgets in edit_button_cb as that button
would be disabled if the calendar is readonly ?

252 +       action = malloc ( sizeof (ECalComponentAlarmAction));
256 +       trigger = malloc ( sizeof (ECalComponentAlarmTrigger));
Not freed. Better to use g_new0.

e_cal_component_alarm_get_attach (alarm, (&attach));
attach should be freed 
const char *str;
unused variable.

The function populate_widgets should be called only when editing alarms.
Could be renamed so that it indicates that the data is from 
existing alarm component.

Please test the patch by changing the alarm values. Alarm should not
popup for old values. Please resend with these changes.

thanks, Chenthill.

On Wed, 2006-01-18 at 20:08 +0530, Johnny Jacob wrote:
> Hi
> 
> Worked on Bug 225816 – Can't edit existing alarm / reminder, only add or remove.
> 
> Please review
> 
> Thanks
> Johnny
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches