[evolution-patches] [gtkhtml] Fix for http://bugzilla.gnome.org/show_bug.cgi?id=326366



Hi,

Attached patch fixes http://bugzilla.gnome.org/show_bug.cgi?id=326366

ChangeLog explains it all.

Let me know your comments.

Thanks,

V. Varadhan

(P.S:- gtkhtml.c defines a global variable to hold
gconf_client_get_default () value, but, in many places directly calls
the function instead of using the global variable.  Guess, this may need
some cleanup)
Index: src/ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.2153
diff -u -p -r1.2153 ChangeLog
--- src/ChangeLog	16 Jan 2006 06:25:21 -0000	1.2153
+++ src/ChangeLog	18 Jan 2006 12:14:15 -0000
@@ -1,3 +1,9 @@
+2006-01-18  Veerapuram Varadhan <vvaradhan novell com>
+
+	** Fixes bug #326366
+
+	* gtkhtml.c: Make sure gconf_client is not NULL.
+	
 2006-01-16  Srinivasa Ragavan  <sragavan novell com>
 
 	** Fixes bug #256142 (Committing Rohini's patch)
Index: src/gtkhtml.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/gtkhtml.c,v
retrieving revision 1.611
diff -u -p -r1.611 gtkhtml.c
--- src/gtkhtml.c	11 Sep 2005 04:24:32 -0000	1.611
+++ src/gtkhtml.c	18 Jan 2006 12:14:16 -0000
@@ -3120,6 +3120,9 @@ init_properties_widget (GtkHTML *html)
 
 	prop = get_class_properties (html);
 
+	if (!gconf_client)
+		gconf_client = gconf_client_get_default ();
+
 	html->priv->notify_spell_id = gconf_client_notify_add (gconf_client, GNOME_SPELL_GCONF_DIR,
 							       client_notify_spell_widget, html, NULL, &gconf_error);
 	if (gconf_error) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]