[evolution-patches] Fix for bug#256257 [UI]
- From: Rohini <srohini novell com>
- To: evolution-patches gnome org
- Subject: [evolution-patches] Fix for bug#256257 [UI]
- Date: Thu, 12 Jan 2006 13:30:10 +0530
Hi
Attached Fix for bug#256257 - Find in Message dialog - UI suggestions
Please Review
Thanks,
Rohini
Index: em-format-html-display.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-format-html-display.c,v
retrieving revision 1.83
diff -u -p -r1.83 em-format-html-display.c
--- em-format-html-display.c 1 Jan 2006 13:56:30 -0000 1.83
+++ em-format-html-display.c 12 Jan 2006 07:41:31 -0000
@@ -476,6 +476,8 @@ efhd_update_matches(EMFormatHTMLDisplay
sprintf(str, fmt, e_searching_tokenizer_match_count(efhd->search_tok));
gtk_label_set_text((GtkLabel *)p->search_matches_label, str);
}
+ gtk_widget_show((GtkWidget *)p->search_matches_label);
+
}
static void
@@ -593,6 +595,7 @@ em_format_html_display_search(EMFormatHT
g_signal_connect(p->search_case_check, "toggled", G_CALLBACK(efhd_search_case_toggled), efhd);
g_signal_connect(p->search_dialog, "response", G_CALLBACK(efhd_search_response), efhd);
gtk_widget_show((GtkWidget *)p->search_dialog);
+ gtk_widget_hide((GtkWidget *)p->search_matches_label);
}
void
Index: mail-dialogs.glade
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-dialogs.glade,v
retrieving revision 1.6
diff -u -p -r1.6 mail-dialogs.glade
--- mail-dialogs.glade 20 Dec 2005 10:05:37 -0000 1.6
+++ mail-dialogs.glade 12 Jan 2006 07:42:33 -0000
@@ -132,6 +132,25 @@
</child>
<child>
+ <widget class="GtkCheckButton" id="search_case_check">
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="label" translatable="yes">Case _sensitive</property>
+ <property name="use_underline">True</property>
+ <property name="relief">GTK_RELIEF_NORMAL</property>
+ <property name="focus_on_click">True</property>
+ <property name="active">False</property>
+ <property name="inconsistent">False</property>
+ <property name="draw_indicator">True</property>
+ </widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">False</property>
+ <property name="fill">False</property>
+ </packing>
+ </child>
+
+ <child>
<widget class="GtkLabel" id="search_matches_label">
<property name="visible">True</property>
<property name="label" translatable="yes"></property>
@@ -156,24 +175,6 @@
</packing>
</child>
- <child>
- <widget class="GtkCheckButton" id="search_case_check">
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="label" translatable="yes">Case _sensitive</property>
- <property name="use_underline">True</property>
- <property name="relief">GTK_RELIEF_NORMAL</property>
- <property name="focus_on_click">True</property>
- <property name="active">False</property>
- <property name="inconsistent">False</property>
- <property name="draw_indicator">True</property>
- </widget>
- <packing>
- <property name="padding">0</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
- </child>
</widget>
<packing>
<property name="padding">0</property>
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3768
diff -u -p -r1.3768 ChangeLog
--- ChangeLog 10 Jan 2006 08:10:29 -0000 1.3768
+++ ChangeLog 12 Jan 2006 07:52:16 -0000
@@ -1,3 +1,11 @@
+2006-01-12 Rohini S <srohini novell com>
+ * mail-dialogs.glade: Interchange of label and checkbox
+ positions in Find message dialog
+ * em-format-html-display.c: (efhd_update_matches),
+ (em_format_html_display_search):
+ Hide Matches Label on dialog open and Show Matches Label when
+ required. Fixes bug 246257.
+
2006-01-10 Simon Zheng <simon zheng sun com>
* em-composer-utils.c:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]