Re: [evolution-patches] Re: [Evolution-hackers] Remove duplicate e-util-marshal.list in evolution/widgets/misc
- From: Harry Lu <Harry Lu Sun COM>
- To: Harish Krishnaswamy <kharish novell com>
- Cc: evolution-patches gnome org, "simon.zheng" <Simon Zheng Sun COM>
- Subject: Re: [evolution-patches] Re: [Evolution-hackers] Remove duplicate e-util-marshal.list in evolution/widgets/misc
- Date: Wed, 11 Jan 2006 19:52:36 +0800
Sorry, I only did a make clean and make before the commit. It is part of
my fault, too.
We will be careful next time.
Harry
On Wed, 2006-01-11 at 16:57 +0530, Harish Krishnaswamy wrote:
> Twice bitten the same day, shy forever :-).
> There remains one more reference to e-util-marshal.list in the
> Makefile.am
> that must be removed. Chen has just committed a fix for the same.
>
> Lets remind ourselves to do a make dist to be extra sure about changes
> that remove/rename files.
>
> Thanks Chen.
>
> -Harish
>
>
> On Wed, 2006-01-11 at 18:43 +0800, Harry Lu wrote:
> > Patch committed into CVS HEAD.
> >
> > Both evolution/widgets/misc/e-util-marshal.list and
> > evolution/e-util/e-marshal.list are removed.
> >
> > Harry
> > On Wed, 2006-01-11 at 15:41 +0530, Srinivasa Ragavan wrote:
> > > Looks fine to me.
> > >
> > > -Srini
> > > On Tue, 2006-01-10 at 23:31 +0530, Harish Krishnaswamy wrote:
> > > > This change looks fine to me. Actually, it must have been just oversight
> > > > not having removed e-util-marshal.list from evolution/widgets/misc.
> > > >
> > > > Srini has been working on widgets/* more than any of us lately, though.
> > > > Thoughts, Srini ?
> > > >
> > > > Thanks,
> > > > Harish
> > > > On Tue, 2006-01-10 at 18:47 +0800, simon.zheng wrote:
> > > > > Hi all,
> > > > >
> > > > > Here is bug information.
> > > > > http://bugzilla.gnome.org/show_bug.cgi?id=323529
> > > > >
> > > > > We found another duplicate file "e-util-marshal.list". There's two
> > > > > copies of e-util-marshal.list in and "evo/e-util" and
> > > > > "evo/widgets/misc". They're 100% identical. What's more, we noticed the
> > > > > other modules in evo/widgets, such as evo/widgets/table and
> > > > > evo/widgets/text, use the copy in evo/e-util rather than their own
> > > > > built-in copies. We think the one in evo/widgets/misc might be dropped.
> > > > >
> > > > > Attached the patch, pls review and comment.
> > > > >
> > > > > Thanks,
> > > > > -Simon
> > > > > _______________________________________________
> > > > > Evolution-hackers mailing list
> > > > > Evolution-hackers gnome org
> > > > > http://mail.gnome.org/mailman/listinfo/evolution-hackers
> > > >
> > > > _______________________________________________
> > > > Evolution-hackers mailing list
> > > > Evolution-hackers gnome org
> > > > http://mail.gnome.org/mailman/listinfo/evolution-hackers
> > >
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> >
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]