Re: [evolution-patches][Contacts] Fix for bug#32574



Looks good.
Please commit to cvs head and gnome-2-12 branches.

Thanks,
Sushma.

On Wed, 2006-01-04 at 19:47 +0800, ShiPu wrote:
> hi,
> 
> 	sorry for adding a wrong attach, pls ignore the last mail.
> 
> 	If evolution running on solaris10, and based on SUN LDAP libraries.
> when new an addressbook on LDAP servers, it would cause a crash.
> 
>         It cause by eabc_details_search() in
> addressbook/gui/component/addressbook-config.c. In Linux, because we use
> Openldap libraries, ldap_url_parse("ldap://:389/??one";, &lud) would
> return LDAP_SUCCESS when url's host==NULL. But in Sun LDAP libraries(or
> mozilla ldap libs) ldap_url_parse() would not return LDAP_SUCCESS if
> url's host==NULL, so lud would be NULL and lud should be checked before
> using it. But when using lud->lud_scope, it don't do this way.
>         
>         this patch adds a check before using lud->scope. Is there
> anybody could review it for me?
> 
> thanks,
> 
> jerry
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]