[evolution-patches] [Gal] Fixes for #331400



Hi Varadhan,

Bug #331400 - Accented characters are displayed incorrectly in Tasks
print preview.

As discussion at IRC, adding some comments in patch.
Resending the patch for your review.

Thanks,
-Simon
Index: table/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/ChangeLog,v
retrieving revision 1.20
diff -u -p -r1.20 ChangeLog
--- table/ChangeLog	24 Feb 2006 07:56:58 -0000	1.20
+++ table/ChangeLog	28 Feb 2006 12:09:21 -0000
@@ -1,3 +1,12 @@
+2006-02-28  Simon Zheng  <simon zheng sun com>
+
+	** Fixes bug #331400
+
+	* e-cell-text.c: (ect_print_height): Table item height is decided 
+	by the max cell height in item. And cell-text is just one of cells.
+	As done by ect_print(), to leave some margin for text, 2 for footer,
+	2 for header, actual print height should be 16 + 4. 
+
 2006-02-24  Srinivasa Ragavan  <sragavan novell com>
 
 	** Fixes bug #332408
Index: table/e-cell-text.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/e-cell-text.c,v
retrieving revision 1.144
diff -u -p -r1.144 e-cell-text.c
--- table/e-cell-text.c	30 Jan 2006 12:28:20 -0000	1.144
+++ table/e-cell-text.c	28 Feb 2006 12:09:21 -0000
@@ -1370,7 +1370,12 @@ ect_print_height (ECellView *ecell_view,
 		  int model_col, int view_col, int row,
 		  double width)
 {
-	return 16;
+	/* 
+	 * Font size is 16 by default. To leave some margin for cell 
+	 * text area, 2 for footer, 2 for header, actual print height 
+	 * should be 16 + 4.
+`	 */
+	return 16 + 4;
 }
 
 static int


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]