Re: [evolution-patches] fix for a crash in connector [exchange]

[Harish Krishnaswamy <kharish novell com>]

On Wed, 2006-02-22 at 14:09 +0530, pchenthill wrote:
> Hi harish,
>  

> We are trying to access a freed memory location which causes the
> crash.

I see your point on what causes the crash but not so sure about the fix.

while () {

          unref - removed here <<<<<
}

and moved out of the loop  - implies potentially you may be leaking as
you would only free the last value of folder regardless of the number of
iterations on the while loop. 

If indeed it can get executed more than once - you then need to ref it
while adding to the list and unref after use, while retaining the unref
already present in the code (which holds good for all folders whether or
not they might end up in the list).

I am not too familiar with this code...but just curious that this is a
recursive function with a return value, that is never used (not even on
termination).

Thanks,
Harish