Re: [evolution-patches] Improvement to replying to messages without Date:

[Parthasarathi Susarla <sparthasarathi novell com>]

Looks fine.

-partha
On Tue, 2006-02-21 at 10:36 +0200, Tor Lillqvist wrote:
> When replying to a message without Date: header,
> camel_mime_message_get_date() returns CAMEL_MESSAGE_DATE_CURRENT (-1).
> attribution_format() in em-composer-utils.c does not check for this, and
> proceeds to pass this bogus time to gmtime_r(). (Which presumably on
> most Unixes is interpreted as one second before the Unix epoch. The
> Win32 gmtime() returns NULL when given a -1, though... which is what
> made me notice this.)
> 
> It would be better to then just return an attribution without date like
> "${Sender} wrote:", but as we are in a string freeze, a workaround is to
> look for the Received: headers instead.
> 
> OK to commit?
> 
> --tml
> 
> 
> 
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches