[evolution-patches] Please pay attention to "compiler-warnings"
- From: "Veerapuram Varadhan" <vvaradhan novell com>
- To: <evolution-hackers gnome org>, <evolution-patches gnome org>
- Cc:
- Subject: [evolution-patches] Please pay attention to "compiler-warnings"
- Date: Tue, 14 Feb 2006 06:18:54 -0700
Hi,
Today, I noticed the following error, when I run the HEAD evolution. It
is due to a typo introduced by recent commits to the plugin.
(evolution-2.6:28994): e-utils-WARNING **: can't load plugin
'/home/bhargavi/mbe/lib/evolution/2.6/plugins/liborg-gnome-itip-formatter.so:
undefined symbol: gfree'
This might look trivial, but actually, is a potential segfault in 64-bit
machines.
Before committing any patches, please do a "make clean" and make and fix
any compiler warning. In this case, it would be,
itip-formatter.c: In function 'itip_formatter_page_factory':
itip-formatter.c:2006: warning: implicit declaration of function 'gfree'
Attaching a patch for the same.
Thanks,
V. Varadhan
Index: plugins/itip-formatter/itip-formatter.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/itip-formatter/itip-formatter.c,v
retrieving revision 1.63
diff -u -p -r1.63 itip-formatter.c
--- plugins/itip-formatter/itip-formatter.c 12 Feb 2006 23:15:06 -0000 1.63
+++ plugins/itip-formatter/itip-formatter.c 14 Feb 2006 13:14:29 -0000
@@ -2003,7 +2003,7 @@ itip_formatter_page_factory (EPlugin *ep
frame_label = gtk_label_new ("");
str = g_strdup_printf ("<span weight=\"bold\">%s</span>", _("Conflict Search"));
gtk_label_set_markup (GTK_LABEL (frame_label), str);
- gfree (str);
+ g_free (str);
GTK_MISC (frame_label)->xalign = 0.0;
gtk_box_pack_start (GTK_BOX (frame), frame_label, FALSE, FALSE, 0);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]