Re: [evolution-patches] fix for the bug #329866 [calendar]



Looks good. Please commit and update the bug.

thanks,
harish

On Mon, 2006-02-13 at 13:16 +0530, chen wrote:
> Attached the updated one.
> 
> thanks, Chenthill.
> On Mon, 2006-02-13 at 11:01 +0530, Harish Krishnaswamy wrote:
> > > + const char *i_rid = NULL, d_rid = NULL;
> > 
> > d_rid should be a const char *.
> > 
> > > +
> > > +                               i_rid =
> > > e_cal_component_get_recurid_as_string (ci->comp);
> > > +                               cid->comp =
> > > e_cal_component_get_recurid_as_string (cid->comp);
> > > +
> > > +                               if (i_rid && d_rid && strcmp
> > > (e_cal_component_get_recurid_as_string (ci->comp),
> > > 
> > 
> > d_rid is never assigned a value and will cause the if condition to be
> > FALSE always.
> > 
> > Can you pl. rework the same.
> > 
> > Harish



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]