[evolution-patches] [gtkhtml] Patch for bug 330382 Evolution hangs when navigating mails with both RTL and LTR texts in caret mode
- From: Irene Huang <Irene Huang Sun COM>
- To: "evolution-patches gnome org" <evolution-patches gnome org>
- Subject: [evolution-patches] [gtkhtml] Patch for bug 330382 Evolution hangs when navigating mails with both RTL and LTR texts in caret mode
- Date: Wed, 08 Feb 2006 20:02:35 +0800
Hi,
This fixes the bug 330382. A loop without exits is the reason that
Evolution hangs. Updating the variable dir within the loop solves the
problem.
Please Review
Thanks
--Irene
Index: src/ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.2159
diff -u -r1.2159 ChangeLog
--- src/ChangeLog 6 Feb 2006 09:59:36 -0000 1.2159
+++ src/ChangeLog 8 Feb 2006 11:43:51 -0000
@@ -1,3 +1,10 @@
+2006-02-08 Irene Huang <Irene Huang sun com>
+
+ Fixes bug #330382
+
+ * htmlcursor.c: (html_cursor_down): Check the direction
+ of text (Change the value of dir) even if new_line is not found.
+
2006-02-06 Veerapuram Varadhan <vvaradhan novell com>
** Fixes bug #326366
Index: src/htmlcursor.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlcursor.c,v
retrieving revision 1.74
diff -u -r1.74 htmlcursor.c
--- src/htmlcursor.c 31 Mar 2005 12:44:42 -0000 1.74
+++ src/htmlcursor.c 8 Feb 2006 11:43:51 -0000
@@ -481,11 +481,11 @@
}
new_line = TRUE;
- if (cursor->object->parent)
- dir = html_object_get_direction (cursor->object->parent);
- else
- dir = HTML_DIRECTION_LTR;
}
+ if (cursor->object->parent)
+ dir = html_object_get_direction (cursor->object->parent);
+ else
+ dir = HTML_DIRECTION_LTR;
if (dir == HTML_DIRECTION_RTL) {
if (new_line && x <= target_x) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]